diff options
| author | Laurent P. René de Cotret <LaurentRDC@users.noreply.github.com> | 2020-05-30 08:14:21 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-30 14:14:21 +0200 |
| commit | 8afbb62ed5e969d78d8664df205646504f52f278 (patch) | |
| tree | 3a2d9046a39eb239183832f43bd7121b5b7fd16e /lib/Hakyll/Core | |
| parent | 9656e78869dd8248a8558671a48d2e52dbe7edb5 (diff) | |
| download | hakyll-8afbb62ed5e969d78d8664df205646504f52f278.tar.gz | |
Miscellaneous Windows-specific fixes and CI
Diffstat (limited to 'lib/Hakyll/Core')
| -rw-r--r-- | lib/Hakyll/Core/Identifier/Pattern.hs | 11 | ||||
| -rw-r--r-- | lib/Hakyll/Core/Routes.hs | 8 | ||||
| -rw-r--r-- | lib/Hakyll/Core/Util/String.hs | 7 |
3 files changed, 16 insertions, 10 deletions
diff --git a/lib/Hakyll/Core/Identifier/Pattern.hs b/lib/Hakyll/Core/Identifier/Pattern.hs index 5e2597b..d07402d 100644 --- a/lib/Hakyll/Core/Identifier/Pattern.hs +++ b/lib/Hakyll/Core/Identifier/Pattern.hs @@ -75,6 +75,7 @@ import Text.Regex.TDFA ((=~)) -------------------------------------------------------------------------------- import Hakyll.Core.Identifier import Hakyll.Core.Identifier.Pattern.Internal +import Hakyll.Core.Util.String (removeWinPathSeparator) -------------------------------------------------------------------------------- @@ -183,7 +184,7 @@ matches (Complement p) i = not $ matches p i matches (And x y) i = matches x i && matches y i matches (Glob p) i = isJust $ capture (Glob p) i matches (List l) i = i `S.member` l -matches (Regex r) i = (normaliseRegex $ toFilePath i) =~ r +matches (Regex r) i = (removeWinPathSeparator $ toFilePath i) =~ r matches (Version v) i = identifierVersion i == v @@ -205,7 +206,7 @@ splits = inits &&& tails >>> uncurry zip >>> reverse capture :: Pattern -> Identifier -> Maybe [String] capture (Glob p) i = capture' p (toFilePath i) capture (Regex pat) i = Just groups - where (_, _, _, groups) = ((normaliseRegex $ toFilePath i) =~ pat) :: (String, String, String, [String]) + where (_, _, _, groups) = ((removeWinPathSeparator $ toFilePath i) =~ pat) :: (String, String, String, [String]) capture _ _ = Nothing @@ -263,9 +264,3 @@ fromCaptures' (m : ms) [] = case m of fromCaptures' (m : ms) ids@(i : is) = case m of Literal l -> l `mappend` fromCaptures' ms ids _ -> i `mappend` fromCaptures' ms is - - --------------------------------------------------------------------------------- --- | Normalise filepaths to have '/' as a path separator for Regex matching -normaliseRegex :: FilePath -> FilePath -normaliseRegex = concatMap (\c -> if c == '\\' then ['/'] else [c])
\ No newline at end of file diff --git a/lib/Hakyll/Core/Routes.hs b/lib/Hakyll/Core/Routes.hs index 06bf633..2411db9 100644 --- a/lib/Hakyll/Core/Routes.hs +++ b/lib/Hakyll/Core/Routes.hs @@ -46,7 +46,7 @@ module Hakyll.Core.Routes #if MIN_VERSION_base(4,9,0) import Data.Semigroup (Semigroup (..)) #endif -import System.FilePath (replaceExtension) +import System.FilePath (replaceExtension, normalise) -------------------------------------------------------------------------------- @@ -174,7 +174,11 @@ gsubRoute :: String -- ^ Pattern -> (String -> String) -- ^ Replacement -> Routes -- ^ Resulting route gsubRoute pattern replacement = customRoute $ - replaceAll pattern replacement . toFilePath + normalise . replaceAll pattern (replacement . removeWinPathSeparator) . removeWinPathSeparator . toFilePath + where + -- Filepaths on Windows containing `\\' will trip Regex matching, which + -- is used in replaceAll. We normalise filepaths to have '/' as a path separator + -- using removeWinPathSeparator -------------------------------------------------------------------------------- diff --git a/lib/Hakyll/Core/Util/String.hs b/lib/Hakyll/Core/Util/String.hs index f848369..67c436f 100644 --- a/lib/Hakyll/Core/Util/String.hs +++ b/lib/Hakyll/Core/Util/String.hs @@ -6,6 +6,7 @@ module Hakyll.Core.Util.String , replaceAll , splitAll , needlePrefix + , removeWinPathSeparator ) where @@ -76,3 +77,9 @@ needlePrefix needle haystack = go [] haystack go acc xss@(x:xs) | needle `isPrefixOf` xss = Just $ reverse acc | otherwise = go (x : acc) xs + + +-------------------------------------------------------------------------------- +-- | Translate native Windows path separators '\\' to '/' if present. +removeWinPathSeparator :: String -> String +removeWinPathSeparator = concatMap (\c -> if c == '\\' then ['/'] else [c])
\ No newline at end of file |