summaryrefslogtreecommitdiff
path: root/job.c
AgeCommit message (Collapse)AuthorFilesLines
2015-03-24Ignore ? before the command in SunOS modeIgor Pashev1-0/+2
2015-02-28[SV 44348] Fix handling of shell widlcards on MS-Windows.Eli Zaretskii1-0/+4
* job.c (construct_command_argv_internal): If shell wildcard characters are found inside a string quoted with "..", give up the fast route and go through the shell. Fixes Savannah bug #44348.
2015-01-27Fix bs-nl handling, exit and Environment for VMS.John Malmberg1-3/+24
This fix required a complete rewrite of the command parser vmsjobs.c child_execute_job. The old parser had too many incorrect assumptions about DCL commands and could not be repaired to extended. The parser now more closely parses VMS commands and handles quoted commands and redirection. Command File mode has been improved, but can not fully support bs-nl syntax. VMS Unix shell simulation has been improved. * commands.c: vms_comma_separator is now a run-time setting. * function.c: vms_comma_separator is now a run-time setting. * function.c(func_basename_dir) now reports "[]" or "./" based on VMS crtl runtime setting. * job.c(start_job_command): VMS Handle empty commands propery. * main.c: Add VMS environment variables for run-time settings. * vms_legacy_behavior - Force older behavior. * vms_comma_separator - Commas or spaces for separators. * vms_unix_simulation - Enhanced Posix shell simulation features. * Detect if VMS CRTL is set to report Unix paths instead of VMS. * ':' and '>' are also MAP_DIRSEP on VMS. * makeint.h: Add VMS run-time option variables. * readme.vms: Update to current behavior. * variable.c(define_variable_in_set): Fix VMS Environment variable lookup. * variable.c(define_automatic_variables): Remove some VMS specific automatic variables and use the Unix ones instead. * vms_export_symbol.c: Set max symbol size correctly. * vmsjobs.c: child_execute_job() complete rewrite of VMS comand parsing. * vmsjobs.c(build_vms_cmd): VMS commmand building with shell simulation. Signed-off-by: Paul Smith <psmith@gnu.org>
2014-12-27Fix $(shell) on hosts with 64-bit pid_t.Christian Boos1-1/+2
* function.c: Use pid_t for shell_function_pid. * job.c: Likewise. Copyright-paperwork-exempt: yes
2014-10-20[SV 42447]: VMS simulate exporting symbolsJohn Malmberg1-16/+21
This also includes fixing the most of the exit handling code for VMS. Self tests: Previously about 94 Tests in 36 categories fail. Now about 45 tests in 22 categories fail. Because some tests do not properly clean up, the number of tests that fail can vary by one or two test cases between consecutive runs. * Makefile.am: Add new VMS files. * job.c: add prototype for vms_strsignal(). * job.c: (child_error): Remove VMS specific code as no longer needed. * job.c: (reap_children): The VMS specific code was setting the status to 0 instead of setting it to the proper exit status. * job.h: Add vms_launch_status to struct child. * main.c: (main): Use environment variables for options to use MCR * instead of a foreign command, and to always use command files for subprocesses. For VMS use (set_program_name) routine which is common to ports of other GNU packages to VMS to set the program name used internally. Use (vms_putenv_symbol) to set up symbols to be visible in child programs, including recursive make launched by execve() Start of Bash shell detection code for VMS. * makefile.com: Need nested_include=none for building on VMS search lists. Add vms_progname, vms_exit, and vms_export_symbol. * makefile.vms: Need nested_include=none for building on VMS search lists. Add vms_progname, vms_exit, vms_export_symbol. * makeint.h: Make sure non-standard "VMS" macro is defined. Add prototypes for new VMS routines. Remove VMS-specific failure codes. * vmsjobs.c: Add VMS POSIX exit code constants. (_is_unixy_shell): Detect Bash shell. (vms_strsignal): simulate strsignal() on VMS. (vmsHandleChildTerm): fix to properly report failed LIB$SPAWN() exit status codes. Remove code that duplicated code in job.c. (child_execute_job): Export environment symbols before spawning a child and restore afterward unless option to use command files for subprocesses is set. Improve handling of UNIX null commands ":". * vms_exit.c: Provides vms_exit() to detect if an exit code is UNIX or VMS, and converts the UNIX code into a VMS exit code. * vms_export_symbol.c: Routines to create DCL symbols that work like shell aliases or exported shell symbols and clean them up on exit. * vms_export_symbol_test.com: Unit test for vms_export_symbol.c * vms_progname.c: New file: VMS specific replace for progname.c that is used in some GNU projects.
2014-10-02Fix Cygwin compilation error.Eli Zaretskii1-2/+3
* job.c (construct_command_argv_internal) [HAVE_DOS_PATHS]: Fix initializer for sh_chars_sh. Reported by Denis Excoffier<cygwin@Denis-Excoffier.org>.
2014-10-01Avoid compilation warnings.Eli Zaretskii1-0/+4
* main.c (find_and_set_default_shell, main) [WINDOWS32]: Declare variables 'const char *' to avoid compiler warnings. * job.c (construct_command_argv_internal) [!NDEBUG]: Declare 'end' and set it only if NDEBUG is not defined, to avoid compiler warnings.
2014-10-01Treat redirection of standard handles on Windows as it is done on Unix.Eli Zaretskii1-7/+11
* job.c (start_job_command) [WINDOWS32]: Compute outfd and errfd as on Posix platforms, and pass the results to process_easy. * function.c (windows32_openpipe) [WINDOWS32]: Accept an additional argument ERRFD and use it for redirecting the standard error handle passed to the subprocess. (func_shell_base) [WINDOWS32]: Pass the computed errfd to windows32_openpipe.
2014-09-30* job.c: fix make action continuation lines.Hartmut Becker1-0/+2
* vmsjobs.c: fix writing DCL command files when trimming (white spaces and $ signs) especially after a split (command continuation).
2014-09-07Enhance/fix VMS ONESHELL implementation and command executionHartmut Becker1-15/+16
* job.c, vmsjobs.c: fix some double quote and new line handling; implement ONESHELL with writing multiple lines into one DCL command procedure; in ONESHELL allow VMS/make internal redirection only on the first line; fix the created DCL command procedure, which didn't abort on errors; return correct exit status from the DCL command procedure; preserve current procedure verification; make the generated command procedure more robust.
2014-09-07Enhance/fix VMS exit code handling.Hartmut Becker1-4/+9
* commands.c, function.c, hash.c, job.c, main.c, output.c: use MAKE exit codes. * makeint.h: encode make exit codes so that they are VMS compatible. * job.c: check child exit code for VMS style exit codes. * vmsjobs.c: save and return VMS style exit code.
2014-09-07Enhance/fix VMS multi-line support.Hartmut Becker1-1/+22
* job.c: split the command line at a newline. * default.c, vmsjobs.c: change ECHO variable to a pseudo builtin, which ensures that the VMS/DCL ECHO ("write sys$output") is used and is correctly quoted. * vmsjobs.c: remove unused builtin 'rm'.
2014-07-07* various: Assume ISO C89-compliant free() implementation.Paul Smith1-4/+2
2014-07-07* maintMakefile, various: Improve constification of the codebase.Paul Smith1-105/+105
2014-02-01* job.c (set_child_handler_action_flags): [SV 41341]Paul Smith1-4/+14
Ensure signal handler is in place before alarm(1).
2014-01-17Allow the EMX build to use output_sync.Pavel Fedin1-14/+13
job.c (start_job_command): Move the child output diversion out of non-EMX branch. [__EMX__]: Don't use fixed FD_STDOUT and FD_STDERR in the call to child_execute_job. Copyright-paperwork-exempt: yes
2013-11-27Solve some Windows build issues.Stephan T. Lavavej1-2/+2
* main.c (main): Use ONS(), not OSN(). (prepare_mutex_handle_string) [WINDOWS32]: Use %Ix formatting to support both 32bit and 64bit systems. * job.c (free_child, new_job): Use ONS(), not OSN(). * w32/subproc/w32err.c (map_windws32_error_to_string): Use O() when calling fatal(). Copyright-paperwork-exempt: yes
2013-11-23[SV 40361] Don't use vsnprintf(), which is an ISO C99 function.Paul Smith1-29/+43
* output.c (error, fatal, message): Take an extra argument specifying how many bytes are used by the formatted arguments. (get_buffer): New function that allocates the requested buffer size. Remove msc_vsnprintf(), vfmtconcat(), and fmtconcat() as unneeded. * makeint.h: Declare various helper macros for generating output. * *.c: Change all error(), fatal(), message() calls to use the macros, or pass the extra length argument directly.
2013-09-29Fix build failures on EMX for output-sync support.Paul Smith1-3/+3
2013-09-21Invert the #define for output-sync: turn it off with NO_OUTPUT_SYNCPaul Smith1-6/+6
2013-09-21Ensure that stderr from shell functions in recipes is synced.Paul Smith1-63/+90
2013-09-14Support the -Orecurse option properly.Paul Smith1-2/+2
In this mode we still collect all the output from a given target and dump it at once. However we don't treat recursive lines any differently from non-recursive lines. Also we don't print enter/leave messages after every dump. However we do ensure that we always print them once to stdout, so the parent make will collect it properly.
2013-09-12Enhance the output sync mode.Paul Smith1-322/+65
Create a new file, output.c, and collect functions that generate output there. We introduce a new global context specifying where output should go (to stdout or to a sync file), and the lowest level output generator chooses where to write output based on that context. This allows us to set the context globally, and all operations that write output (including functions like $(info ...) etc.) will use it. Removed the "--trace=dir" capability. It was too confusing. If you have directory tracking enabled then output sync will print the enter/leave message for each synchronized block. If you don't want that, disable directory tracking.
2013-07-21[Bug #39158] Source cleanups suggested by cppcheck utility.Paul Smith1-18/+12
2013-07-21Safety cleanups: ensure OUTFD is -1 when closed.Paul Smith1-6/+9
2013-07-14Modify the update_status field in struct file to be an enum.Paul Smith1-9/+9
Makes the code a little clearer/cleaner, and solves a problem on systems where a char is unsigned by default.
2013-06-22Compare internal commands of non-Unix shells on Windows case-insensitively.Eli Zaretskii1-2/+2
job.c (construct_command_argv_internal) [WINDOWS32]: Use case-insensitive comparison with internal commands of non-Unix shells.
2013-06-22Create a character map to use for locating stop-points in strings.Paul Smith1-1/+1
In various places we were passing flags and characters to compare, then using complex conditionals to see where to stop in string searches. Performance numbers reveal that we were spending as much as 23% of our processing time in these functions, most of it in the comparison lines. Instead create a character map and use a single bitwise comparison to determine if this is any one of the stop characters.
2013-05-26[SV #39035] Compare OUT to the beginning of the OUT var/func, not IN.Paul Smith1-1/+3
2013-05-18Support "move" as internal shell command on Windows with cmd.exe.Eli Zaretskii1-2/+2
job.c (construct_command_argv_internal) <sh_cmds_dos> [WINDOWS32]: Add "move". Fixes Savannah bug #30714.
2013-05-17Update source file format: remove TABs, use GNU coding styles.Paul Smith1-794/+809
2013-05-17Update copyright for changes in 2013.Paul Smith1-1/+1
2013-05-13Add new --trace[=MODE] flags, with --trace=dirPaul Smith1-7/+13
This mode replaces the previous heuristic setting enabled with -O, where we would log directory enter/leave for each synchronized output. Now we only do that if --trace=dir is given.
2013-05-11Avoid printing stdout and stderr messages without a newline between them.Eli Zaretskii1-1/+1
job.c (child_out): Output the newline following the message before fllush-ing the stream. Avoids displaying the following failure message, which goes to stderr, on the same line.
2013-05-06Remove use of vfork().Paul Smith1-5/+4
GCC was giving us warnings, most OS's now just run fork() when you call vfork(), and looking at the standard definition of vfork() we are a long way from using it safely anyway: you're not allowed to even call a function before you exec().
2013-05-05cosmetics: fix few innocuous typosStefano Lattarini1-1/+1
Most of these were found using Lucas De Marchi's 'codespell' tool. * ChangeLog: Fix minor typos. * ChangeLog.2: Likewise. * README.Amiga: Likewise. * TODO.private: Likewise. * function.c: Likewise. * glob/glob.h: Likewise. * job.c: Likewise. * main.c: Likewise. * readme.vms: Likewise. * remake.c: Likewise. * tests/ChangeLog: Likewise. * tests/NEWS: Likewise. * tests/README: Likewise. * tests/scripts/variables/private: Likewise. * vmsdir.h: Likewise. * signame.c: Likewise. While at it, improve line wrapping in the touched comment. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
2013-05-05Rename the -O "job" mode to "line" and "make" to "recurse".Paul Smith1-2/+2
2013-05-05Ensure command lines are written synchronously with -O.Paul Smith1-63/+63
If output-sync is enabled, have make write the command line to the temp file instead of printing it directly to the screen to ensure that the output is ordered properly. Also, remove extraneous enter/leave operations by having them printed directly when dumping temp file output.
2013-05-04Don't pump output to the descriptor, as we use FILE* elsewhere.Paul Smith1-49/+29
2013-05-04Improve sync handling for -Ojob/-Otarget and recursion.Paul Smith1-125/+142
If we are not going to sync a command line then dump any collected output first to preserve ordering. Do some code cleanup: * Move the handle init to a separate function. * Move the temp file truncation to the output function. * Remember whether we sync in a variable for readability. * Handle EINTR and short writes in child_out(). * Always call sync_output() in case output_sync was changed due to error.
2013-05-04Fix a possibly confusing comment at end of pump_from_tmp_fd.Eli Zaretskii1-1/+2
2013-05-04Fix the MS-Windows branch of output_sync code.Eli Zaretskii1-2/+1
job.c (start_job_command): Make the condition for creating a temporary output file be identical to the Posix code branch. Suggested by Frank Heckenbach <f.heckenbach@fh-soft.de>.
2013-05-01Fix treatment of whitespace after a backslash on MS-Windows.Eli Zaretskii1-0/+9
job.c (construct_command_argv_internal): Don't treat a backslash as an escape character before whitespace, if the shell is not a Posix shell. For the description of the problem, see http://lists.gnu.org/archive/html/make-w32/2013-04/msg00014.html.
2013-05-01job.c (start_job_command) [WINDOWS32]: Make the same fix forEli Zaretskii1-2/+4
MS-Windows as the previous commit did for Posix platforms.
2013-05-01Don't synchronize output for recursive make unless -OmakePaul Smith1-2/+4
2013-04-29Fix the .ONESHELL operation on MS-Windows.Eli Zaretskii1-3/+3
job.c (construct_command_argv_internal) [WINDOWS32]: Return right after generating new_argv for one_shell case. This fixes the Windows build for both Unixy shell and stock Windows shells.
2013-04-28Ensure error messages are printed with sync'd output.Paul Smith1-17/+58
Enhance the child_error() function so that it will write error output to the child's sync output buffer, if it exists. If it doesn't the output goes to stdout/stderr.
2013-04-28Small cleanups and fixes.Paul Smith1-2/+2
2013-04-28Fix a few compiler warnings found by Eli.Paul Smith1-3/+4
2013-04-28Add support for per-job output sync.Paul Smith1-24/+43
A new flag to the -O/--output-sync, "job", selects a per-job (that is, per line of a recipe) output synchronization. To support this move the close of the temp file out of the sync_output() function and don't do it until we free the child, since we may call sync_output() multiple times in a given recipe. When we set up for a new temp file, if we're in per-job mode we truncate the file and seek to the beginning to re-use it for every job.
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-05 12:52:04 +0000