aboutsummaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorMaxim Epishchev <epishev@garant.ru>2016-02-03 14:34:44 +0300
committerMaxim Epishchev <epishev@garant.ru>2016-02-03 14:34:44 +0300
commit340c1c44bad78992ec49746d3776c3cff1a96fbd (patch)
tree722b0cc5d457a02e4e8fd283216fcec1b3e16a5b /src/test
parent4b880c7045ebf42974f833ffe9b11084c86c3408 (diff)
downloadbbprb-340c1c44bad78992ec49746d3776c3cff1a96fbd.tar.gz
Limit size "key" field in BitBucket POST API
Refactoring method ApiClient::computeAPIKey() to check maximum size of computed key. Now field size contolled by special constant ApiClient::MAX_KEY_SIZE_BB_API. This changes will resolve, in my opinion, issue with continuously rebuilding: method ApiClient::hasBuildStatus() fail and PR's are always trigger new builds.
Diffstat (limited to 'src/test')
-rw-r--r--src/test/java/BitbucketBuildFilterTest.java9
-rw-r--r--src/test/java/BitbucketBuildRepositoryTest.java115
2 files changed, 120 insertions, 4 deletions
diff --git a/src/test/java/BitbucketBuildFilterTest.java b/src/test/java/BitbucketBuildFilterTest.java
index 9b84e73..3b35dbc 100644
--- a/src/test/java/BitbucketBuildFilterTest.java
+++ b/src/test/java/BitbucketBuildFilterTest.java
@@ -5,17 +5,20 @@ import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketPullRequ
import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketRepository;
import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.bitbucket.ApiClient;
import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.bitbucket.Pullrequest;
+
import java.util.Calendar;
import java.util.LinkedList;
import java.util.List;
import java.util.regex.Pattern;
+
import jenkins.plugins.git.AbstractGitSCMSource;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.WithoutJenkins;
+
import org.easymock.*;
import org.junit.Test;
-import static org.junit.Assert.*;
import org.junit.Rule;
-import org.jvnet.hudson.test.JenkinsRule;
-import org.jvnet.hudson.test.WithoutJenkins;
+import static org.junit.Assert.*;
/**
* Tests
diff --git a/src/test/java/BitbucketBuildRepositoryTest.java b/src/test/java/BitbucketBuildRepositoryTest.java
index bb6de8f..5f1aca2 100644
--- a/src/test/java/BitbucketBuildRepositoryTest.java
+++ b/src/test/java/BitbucketBuildRepositoryTest.java
@@ -1,25 +1,41 @@
+import antlr.ANTLRException;
+
import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketBuildTrigger;
import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketPullRequestsBuilder;
import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketRepository;
import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.bitbucket.ApiClient;
+
import com.cloudbees.plugins.credentials.CredentialsProvider;
import com.cloudbees.plugins.credentials.CredentialsScope;
import com.cloudbees.plugins.credentials.CredentialsStore;
import com.cloudbees.plugins.credentials.domains.Domain;
import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
+
+import com.google.common.base.Function;
+import com.google.common.collect.Collections2;
+
+import java.io.UnsupportedEncodingException;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+import java.util.Arrays;
+import java.util.Collection;
import org.easymock.*;
import org.junit.Test;
import static org.junit.Assert.*;
import org.junit.Rule;
+import org.junit.Assert;
import org.jvnet.hudson.test.JenkinsRule;
+
import jenkins.model.Jenkins;
+import org.jvnet.hudson.test.WithoutJenkins;
+
+import org.apache.commons.codec.binary.Hex;
import org.apache.commons.httpclient.Credentials;
import org.apache.commons.httpclient.HttpClient;
import org.apache.commons.httpclient.HttpState;
import org.apache.commons.httpclient.UsernamePasswordCredentials;
import org.apache.commons.httpclient.auth.AuthScope;
-import org.junit.Assert;
interface ICredentialsInterceptor {
@@ -150,4 +166,101 @@ public class BitbucketBuildRepositoryTest {
try { repo.postPullRequestApproval("prId"); } catch(Error e) { assertTrue(e instanceof AssertionError); }
}
+
+ class MD5HasherFunction implements Function<String, String> {
+ protected final MessageDigest MD5;
+ public MD5HasherFunction(MessageDigest md5) { this.MD5 = md5; }
+ public String apply(String f) {
+ try { return new String(Hex.encodeHex(MD5.digest(f.getBytes("UTF-8")))); } catch(UnsupportedEncodingException e) { }
+ return null;
+ }
+ }
+
+ class SHA1HasherFunction implements Function<String, String> {
+ protected final MessageDigest SHA1;
+ public SHA1HasherFunction(MessageDigest sha1) { this.SHA1 = sha1; }
+ public String apply(String f) {
+ try { return new String(Hex.encodeHex(SHA1.digest(f.getBytes("UTF-8")))); } catch(UnsupportedEncodingException e) { }
+ return null;
+ }
+ }
+
+ @Test
+ @WithoutJenkins
+ public void repositoryProjectIdTest() throws ANTLRException, NoSuchAlgorithmException, UnsupportedEncodingException {
+ BitbucketBuildTrigger trigger = new BitbucketBuildTrigger(
+ "", "@hourly",
+ "JenkinsCID",
+ "foo",
+ "bar",
+ "", "",
+ "", true,
+ "jenkins", "Jenkins", "",
+ true,
+ true
+ );
+
+ BitbucketPullRequestsBuilder builder = EasyMock.createMock(BitbucketPullRequestsBuilder.class);
+ EasyMock.expect(builder.getTrigger()).andReturn(trigger).anyTimes();
+
+ final MessageDigest MD5 = MessageDigest.getInstance("MD5");
+
+ String[] projectIds = new String[] {
+ "one",
+ "Second project",
+ "Project abstract 1.1",
+ "Good project, careated at " + (new java.util.Date()).toString(),
+ };
+
+ Collection<String> hashedProjectIdsCollection = Collections2.transform(Arrays.asList(projectIds), new MD5HasherFunction(MD5));
+ String[] hashedPojectIds = hashedProjectIdsCollection.toArray(new String[hashedProjectIdsCollection.size()]);
+
+ for(String projectId : hashedPojectIds) {
+ EasyMock.expect(builder.getProjectId()).andReturn(projectId).times(1);
+ }
+ EasyMock.replay(builder);
+
+ BitbucketRepository repo = new BitbucketRepository("", builder);
+ repo.init();
+
+ for(String projectId : projectIds) {
+ String hashMD5 = new String(Hex.encodeHex(MD5.digest(projectId.getBytes("UTF-8"))));
+ String buildStatusKey = repo.getClient().buildStatusKey(builder.getProjectId());
+
+ assertTrue(buildStatusKey.length() <= ApiClient.MAX_KEY_SIZE_BB_API);
+ assertEquals(buildStatusKey, "jenkins-" + hashMD5);
+ }
+ }
+
+ @Test
+ @WithoutJenkins
+ public void triggerLongCIKeyTest() throws ANTLRException, NoSuchAlgorithmException {
+ BitbucketBuildTrigger trigger = new BitbucketBuildTrigger(
+ "", "@hourly",
+ "JenkinsCID",
+ "foo",
+ "bar",
+ "", "",
+ "", true,
+ "jenkins-too-long-ci-key", "Jenkins", "",
+ true,
+ true
+ );
+
+ final MessageDigest MD5 = MessageDigest.getInstance("MD5");
+ final MessageDigest SHA1 = MessageDigest.getInstance("SHA1");
+
+ BitbucketPullRequestsBuilder builder = EasyMock.createMock(BitbucketPullRequestsBuilder.class);
+ EasyMock.expect(builder.getTrigger()).andReturn(trigger).anyTimes();
+ EasyMock.expect(builder.getProjectId()).andReturn((new MD5HasherFunction(MD5)).apply("projectId")).anyTimes();
+ EasyMock.replay(builder);
+
+ BitbucketRepository repo = new BitbucketRepository("", builder);
+ repo.init();
+
+ String buildStatusKey = repo.getClient().buildStatusKey(builder.getProjectId());
+ assertTrue(buildStatusKey.length() <= ApiClient.MAX_KEY_SIZE_BB_API);
+ assertFalse(buildStatusKey.startsWith("jenkins-"));
+ assertEquals((new SHA1HasherFunction(SHA1)).apply("jenkins-too-long-ci-key" + "-" + builder.getProjectId()), buildStatusKey);
+ }
}