Add tests for integration CredentialsSupport functional

By default we using username/password from original text fields (config.jelly).
If credentials ID provided in plugin settings - using them for BitBucket API auth.

2 files changed, 154 insertions, 29 deletions

diff --git a/src/test/java/BitbucketBuildFilterTest.java b/src/test/java/BitbucketBuildFilterTest.java
index 0fabfe4..9b84e73 100644
--- a/src/test/java/BitbucketBuildFilterTest.java
+++ b/src/test/java/BitbucketBuildFilterTest.java
@@ -1,8 +1,3 @@
-/*
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
- */
 
 import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketBuildFilter;
 import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketCause;
@@ -10,9 +5,7 @@ import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketPullRequ
 import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketRepository;
 import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.bitbucket.ApiClient;
 import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.bitbucket.Pullrequest;
-import java.util.Arrays;
 import java.util.Calendar;
-import java.util.Collection;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.regex.Pattern;
@@ -25,8 +18,7 @@ import org.jvnet.hudson.test.JenkinsRule;
 import org.jvnet.hudson.test.WithoutJenkins;
 
 /**
- *
- * @author maxvodo
+ * Tests
  */
 public class BitbucketBuildFilterTest {
   
@@ -288,24 +280,4 @@ public class BitbucketBuildFilterTest {
     for(Pullrequest.Comment comment : comments)
       assertFalse(repo.hasMyBuildTagInTTPComment(comment.getContent(), myBuildKey));
   }
-  
-  //@Test
-  @WithoutJenkins
-  public void ttpCommentTest() {    
-    ApiClient client = EasyMock.createNiceMock(ApiClient.class);
-    Collection<List<Pullrequest>> prs = new LinkedList<List<Pullrequest>>();
-    
-    prs.add(Arrays.asList(new Pullrequest[] {
-      new Pullrequest()
-    }));
-    
-    for(List<Pullrequest> pr : prs) EasyMock.expect(client.getPullRequests()).andReturn(pr).times(1);
-    BitbucketPullRequestsBuilder builder = EasyMock.createMock(BitbucketPullRequestsBuilder.class);
-    EasyMock.replay(client, builder);
-    
-    BitbucketRepository repo = new BitbucketRepository("", builder);
-    repo.init(client);
-    
-    Collection<Pullrequest> targetPRs = repo.getTargetPullRequests();
-  }
 }
diff --git a/src/test/java/BitbucketBuildRepositoryTest.java b/src/test/java/BitbucketBuildRepositoryTest.java
new file mode 100644
index 0000000..bb6de8f
--- /dev/null
+++ b/src/test/java/BitbucketBuildRepositoryTest.java
@@ -0,0 +1,153 @@
+
+import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketBuildTrigger;
+import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketPullRequestsBuilder;
+import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.BitbucketRepository;
+import bitbucketpullrequestbuilder.bitbucketpullrequestbuilder.bitbucket.ApiClient;
+import com.cloudbees.plugins.credentials.CredentialsProvider;
+import com.cloudbees.plugins.credentials.CredentialsScope;
+import com.cloudbees.plugins.credentials.CredentialsStore;
+import com.cloudbees.plugins.credentials.domains.Domain;
+import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
+import org.easymock.*;
+import org.junit.Test;
+import static org.junit.Assert.*;
+import org.junit.Rule;
+import org.jvnet.hudson.test.JenkinsRule;
+import jenkins.model.Jenkins;
+import org.apache.commons.httpclient.Credentials;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpState;
+import org.apache.commons.httpclient.UsernamePasswordCredentials;
+import org.apache.commons.httpclient.auth.AuthScope;
+import org.junit.Assert;
+
+
+interface ICredentialsInterceptor {
+  void assertCredentials(Credentials actual);
+}
+
+/**
+ * Utility class for interceptor functionality
+ * @param <T> 
+ */
+class HttpClientInterceptor<T extends ICredentialsInterceptor> extends HttpClient {  
+  
+  class CredentialsInterceptor<T extends ICredentialsInterceptor> extends HttpState {
+    private final T interceptor;
+    public CredentialsInterceptor(T interceptor) { this.interceptor = interceptor; }
+    
+    @Override
+    public synchronized void setCredentials(AuthScope authscope, Credentials credentials) {      
+      super.setCredentials(authscope, credentials);
+      this.interceptor.assertCredentials(credentials);
+      throw new AssertionError();
+    }    
+  }  
+  
+  private final T interceptor;
+  public HttpClientInterceptor(T interceptor) { this.interceptor = interceptor; }
+  
+  @Override
+  public synchronized HttpState getState() { return new CredentialsInterceptor(this.interceptor); }  
+}
+
+/**
+ * Utility class for credentials assertion
+ * Used with 
+ * @author maxvodo
+ */
+class AssertCredentials implements ICredentialsInterceptor {
+  private final Credentials expected;
+  public AssertCredentials(Credentials expected) { this.expected = expected; }
+
+  public void assertCredentials(Credentials actual) {
+    if (actual == null) assertTrue(this.expected == null); 
+                   else assertTrue(this.expected != null);        
+
+    if (actual instanceof UsernamePasswordCredentials) {
+      UsernamePasswordCredentials actual_ = (UsernamePasswordCredentials)actual,
+                                  expected_ = (UsernamePasswordCredentials)this.expected;
+      assertNotNull(expected_);
+      Assert.assertArrayEquals(new Object[] {
+        actual_.getUserName(), actual_.getPassword()
+      }, new Object[] {
+        expected_.getUserName(), expected_.getPassword()
+      });
+    }
+  }      
+}
+
+/**
+ * Tests
+ */
+public class BitbucketBuildRepositoryTest {
+
+  @Rule
+  public JenkinsRule jRule = new JenkinsRule();  
+  
+  @Test  
+  public void repositorySimpleUserPasswordTest() throws Exception {
+    BitbucketBuildTrigger trigger = new BitbucketBuildTrigger(
+      "", "@hourly",
+      "JenkinsCID",
+      "foo",
+      "bar",
+      "", "",
+      "", true,
+      "", "", "",
+      true, 
+      true
+    );
+    
+    BitbucketPullRequestsBuilder builder = EasyMock.createMock(BitbucketPullRequestsBuilder.class); 
+    EasyMock.expect(builder.getTrigger()).andReturn(trigger).anyTimes();
+    EasyMock.replay(builder);
+    
+    ApiClient.HttpClientFactory httpFactory = EasyMock.createMock(ApiClient.HttpClientFactory.class);
+    EasyMock.expect(httpFactory.getInstanceHttpClient()).andReturn(
+      new HttpClientInterceptor(new AssertCredentials(new UsernamePasswordCredentials("foo", "bar")))
+    ).anyTimes();
+    EasyMock.replay(httpFactory);            
+    
+    BitbucketRepository repo = new BitbucketRepository("", builder);
+    repo.init(httpFactory.getClass());
+    
+    try { repo.postPullRequestApproval("prId"); } catch(Error e) { assertTrue(e instanceof AssertionError); }
+  }
+  
+  @Test  
+  public void repositoryCtorWithTriggerTest() throws Exception {
+    BitbucketBuildTrigger trigger = new BitbucketBuildTrigger(
+      "", "@hourly",
+      "JenkinsCID",
+      "foo",
+      "bar",
+      "", "",
+      "", true,
+      "", "", "",
+      true, 
+      true
+    );          
+    
+    BitbucketPullRequestsBuilder builder = EasyMock.createMock(BitbucketPullRequestsBuilder.class); 
+    EasyMock.expect(builder.getTrigger()).andReturn(trigger).anyTimes();
+    EasyMock.replay(builder);
+    
+    CredentialsStore store = CredentialsProvider.lookupStores(Jenkins.getInstance()).iterator().next();
+    assertNotNull(store);
+    store.addCredentials(Domain.global(), new UsernamePasswordCredentialsImpl(
+      CredentialsScope.GLOBAL, "JenkinsCID", "description", "username", "password"
+    ));
+    
+    ApiClient.HttpClientFactory httpFactory = EasyMock.createMock(ApiClient.HttpClientFactory.class);
+    EasyMock.expect(httpFactory.getInstanceHttpClient()).andReturn(
+      new HttpClientInterceptor(new AssertCredentials(new UsernamePasswordCredentials("username", "password")))
+    ).anyTimes();
+    EasyMock.replay(httpFactory);  
+    
+    BitbucketRepository repo = new BitbucketRepository("", builder);
+    repo.init(httpFactory.getClass());        
+    
+    try { repo.postPullRequestApproval("prId"); } catch(Error e) { assertTrue(e instanceof AssertionError); }                
+  }
+}