From c43e2dc0f4ce639c8d0bd156afea2fd07ffc91ff Mon Sep 17 00:00:00 2001 From: John MacFarlane Date: Sun, 13 Dec 2020 10:45:03 -0800 Subject: RST writer: better image handling. - An image alone in its paragraph (but not a figure) is now rendered as an independent image, with an `alt` attribute if a description is supplied. - An inline image that is not alone in its paragraph will be rendered, as before, using a substitution. Such an image cannot have a "center", "left", or "right" alignment, so the classes `align-center`, `align-left`, or `align-right` are ignored. However, `align-top`, `align-middle`, `align-bottom` will generate a corresponding `align` attribute. Closes #6948. --- test/command/4420.md | 11 ----------- test/command/6948.md | 31 +++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 11 deletions(-) create mode 100644 test/command/6948.md (limited to 'test/command') diff --git a/test/command/4420.md b/test/command/4420.md index 3e7008935..36d697234 100644 --- a/test/command/4420.md +++ b/test/command/4420.md @@ -1,14 +1,3 @@ -``` -% pandoc -f native -t rst -[Image ("",["align-right"],[("width","100px")]) [Str "image"] ("foo.png","")] -^D -|image| - -.. |image| image:: foo.png - :align: right - :width: 100px -``` - ``` % pandoc -f native -t rst [Para [Image ("",["align-right"],[("width","100px")]) [Str "image"] ("foo.png","fig:test")]] diff --git a/test/command/6948.md b/test/command/6948.md new file mode 100644 index 000000000..8803aebe9 --- /dev/null +++ b/test/command/6948.md @@ -0,0 +1,31 @@ +Treat an image alone in its paragraph (but not a figure) +as an independent image: +``` +% pandoc -f native -t rst +[Para [Image ("",["align-center"],[]) [Str "https://pandoc.org/diagram.jpg"] ("https://pandoc.org/diagram.jpg","")]] +^D +.. image:: https://pandoc.org/diagram.jpg + :alt: https://pandoc.org/diagram.jpg + :align: center +``` + +Here we just omit the center attribute as it's not valid: +``` +% pandoc -f native -t rst +[Para [Str "hi",Space,Image ("",["align-center"],[]) [Str "https://pandoc.org/diagram.jpg"] ("https://pandoc.org/diagram.jpg","")]] +^D +hi |https://pandoc.org/diagram.jpg| + +.. |https://pandoc.org/diagram.jpg| image:: https://pandoc.org/diagram.jpg +``` + +But we can use top, middle, or bottom alignment: +``` +% pandoc -f native -t rst +[Para [Str "hi",Space,Image ("",["align-top"],[]) [Str "https://pandoc.org/diagram.jpg"] ("https://pandoc.org/diagram.jpg","")]] +^D +hi |https://pandoc.org/diagram.jpg| + +.. |https://pandoc.org/diagram.jpg| image:: https://pandoc.org/diagram.jpg + :align: top +``` -- cgit v1.2.3