From 87e0728b87846cdacb8866e19b9a8e127490b4bf Mon Sep 17 00:00:00 2001
From: Jesse Rosenthal <jrosenthal@jhu.edu>
Date: Thu, 22 Feb 2018 13:27:34 -0500
Subject: Docx reader: Avoid repeated spans in custom styles.

The previous commit had a bug where custom-style spans would be read
with every recurrsion. This fixes that, and changes the example given
in the manual.
---
 src/Text/Pandoc/Readers/Docx.hs | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

(limited to 'src/Text/Pandoc/Readers')

diff --git a/src/Text/Pandoc/Readers/Docx.hs b/src/Text/Pandoc/Readers/Docx.hs
index 491eea753..775fa1cdd 100644
--- a/src/Text/Pandoc/Readers/Docx.hs
+++ b/src/Text/Pandoc/Readers/Docx.hs
@@ -141,10 +141,12 @@ instance Default DState where
                }
 
 data DEnv = DEnv { docxOptions       :: ReaderOptions
-                 , docxInHeaderBlock :: Bool }
+                 , docxInHeaderBlock :: Bool
+                 , docxCustomStyleAlready :: Bool
+                 }
 
 instance Default DEnv where
-  def = DEnv def False
+  def = DEnv def False False
 
 type DocxContext m = ReaderT DEnv (StateT DState m)
 
@@ -281,8 +283,9 @@ resolveDependentRunStyle rPr
 extraRunStyleInfo :: PandocMonad m => RunStyle -> DocxContext m (Inlines -> Inlines)
 extraRunStyleInfo rPr
   | Just (s, _) <- rStyle rPr = do
+      already <- asks docxCustomStyleAlready
       opts <- asks docxOptions
-      return $ if isEnabled Ext_styles opts
+      return $ if isEnabled Ext_styles opts && not already
                then spanWith ("", [], [("custom-style", s)])
                else id
   | otherwise = return id
@@ -295,32 +298,39 @@ runStyleToTransform rPr
       transform <- runStyleToTransform rPr'
       return $ spanWith ("", [s], []) . transform
   | Just True <- isItalic rPr = do
-      transform <- runStyleToTransform rPr {isItalic = Nothing}
       extraInfo <- extraRunStyleInfo rPr
+      transform <- local (\e -> e{docxCustomStyleAlready = True}) $
+                   runStyleToTransform rPr {isItalic = Nothing}
       return $ emph . extraInfo . transform
   | Just True <- isBold rPr = do
-      transform <- runStyleToTransform rPr {isBold = Nothing}
       extraInfo <- extraRunStyleInfo rPr
+      transform <- local (\e -> e{docxCustomStyleAlready = True}) $
+                   runStyleToTransform rPr {isBold = Nothing}
       return $ strong . extraInfo . transform
   | Just True <- isSmallCaps rPr = do
-      transform <- runStyleToTransform rPr {isSmallCaps = Nothing}
       extraInfo <- extraRunStyleInfo rPr
+      transform <- local (\e -> e{docxCustomStyleAlready = True}) $
+                   runStyleToTransform rPr {isSmallCaps = Nothing}
       return $ smallcaps . extraInfo .transform
   | Just True <- isStrike rPr = do
-      transform <- runStyleToTransform rPr {isStrike = Nothing}
       extraInfo <- extraRunStyleInfo rPr
+      transform <- local (\e -> e{docxCustomStyleAlready = True}) $
+                   runStyleToTransform rPr {isStrike = Nothing}
       return $ strikeout . extraInfo . transform
   | Just SupScrpt <- rVertAlign rPr = do
-      transform <- runStyleToTransform rPr {rVertAlign = Nothing}
       extraInfo <- extraRunStyleInfo rPr
+      transform <- local (\e -> e{docxCustomStyleAlready = True}) $
+                   runStyleToTransform rPr {rVertAlign = Nothing}
       return $ superscript . extraInfo . transform
   | Just SubScrpt <- rVertAlign rPr = do
-      transform <- runStyleToTransform rPr {rVertAlign = Nothing}
       extraInfo <- extraRunStyleInfo rPr
+      transform <- local (\e -> e{docxCustomStyleAlready = True}) $
+                   runStyleToTransform rPr {rVertAlign = Nothing}
       return $ subscript . extraInfo . transform
   | Just "single" <- rUnderline rPr = do
-      transform <- runStyleToTransform rPr {rUnderline = Nothing}
       extraInfo <- extraRunStyleInfo rPr
+      transform <- local (\e -> e{docxCustomStyleAlready = True}) $
+                   runStyleToTransform rPr {rUnderline = Nothing}
       return $ underlineSpan . extraInfo . transform
   | otherwise = extraRunStyleInfo rPr
 
-- 
cgit v1.2.3