From 35cfe2d01b25f42f7720cbdf20a8d2205f7e80e0 Mon Sep 17 00:00:00 2001 From: John MacFarlane Date: Fri, 18 Dec 2020 12:18:23 -0800 Subject: New advice for pre-commit filter. Without `--diff-filter=MA` it will try to lint deletions, and fail because the file is not present. --- CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 00aa1b1cd..0749daeac 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -288,7 +288,8 @@ A good way to ensure no new warnings are introduced is to use a Git before creating a commit: #!/bin/sh - git diff --cached --name-only | grep '\.hs$' | xargs hlint + git diff --diff-filter=MA --cached --name-only | grep '\.hs$' | \ + xargs hlint --hint .hlint.yaml Saving this to `.git/hooks/pre-commit`, and making the script executable, will prevent accidental introduction of potentially -- cgit v1.2.3