summaryrefslogtreecommitdiff
path: root/function.c
AgeCommit message (Collapse)AuthorFilesLines
2013-09-14[SV 39851] Reinstate stack size limit for processes spawned via $(shell)Petr Machata1-1/+8
2013-09-14Support the -Orecurse option properly.Paul Smith1-1/+1
In this mode we still collect all the output from a given target and dump it at once. However we don't treat recursive lines any differently from non-recursive lines. Also we don't print enter/leave messages after every dump. However we do ensure that we always print them once to stdout, so the parent make will collect it properly.
2013-09-12Enhance the output sync mode.Paul Smith1-2/+5
Create a new file, output.c, and collect functions that generate output there. We introduce a new global context specifying where output should go (to stdout or to a sync file), and the lowest level output generator chooses where to write output based on that context. This allows us to set the context globally, and all operations that write output (including functions like $(info ...) etc.) will use it. Removed the "--trace=dir" capability. It was too confusing. If you have directory tracking enabled then output sync will print the enter/leave message for each synchronized block. If you don't want that, disable directory tracking.
2013-07-21[Bug #39158] Source cleanups suggested by cppcheck utility.Paul Smith1-2/+3
2013-06-22Create a character map to use for locating stop-points in strings.Paul Smith1-36/+19
In various places we were passing flags and characters to compare, then using complex conditionals to see where to stop in string searches. Performance numbers reveal that we were spending as much as 23% of our processing time in these functions, most of it in the comparison lines. Instead create a character map and use a single bitwise comparison to determine if this is any one of the stop characters.
2013-05-27Porting to VMS, from Hartmut Becker.Paul Smith1-0/+1
2013-05-17Update source file format: remove TABs, use GNU coding styles.Paul Smith1-338/+337
2013-05-17Update copyright for changes in 2013.Paul Smith1-1/+1
2013-05-05cosmetics: fix few innocuous typosStefano Lattarini1-1/+1
Most of these were found using Lucas De Marchi's 'codespell' tool. * ChangeLog: Fix minor typos. * ChangeLog.2: Likewise. * README.Amiga: Likewise. * TODO.private: Likewise. * function.c: Likewise. * glob/glob.h: Likewise. * job.c: Likewise. * main.c: Likewise. * readme.vms: Likewise. * remake.c: Likewise. * tests/ChangeLog: Likewise. * tests/NEWS: Likewise. * tests/README: Likewise. * tests/scripts/variables/private: Likewise. * vmsdir.h: Likewise. * signame.c: Likewise. While at it, improve line wrapping in the touched comment. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
2013-04-27Support --output-sync on MS-Windows.Eli Zaretskii1-12/+24
w32/compat/posixfcn.c: New file, with emulations of Posix functions and Posix functionality for MS-Windows. w32/subproc/sub_proc.c: Include io.h. (process_noinherit): New function, forces a file descriptor to not be inherited by child processes. (process_easy): Accept two additional arguments, and use them to set up the standard output and standard error handles of the child process. w32/include/sub_proc.h (process_easy): Adjust prototype. (process_noinherit): Add prototype. read.c [WINDOWS32]: Include windows.h and sub_proc.h. makeint.h (LOCALEDIR) [WINDOWS32}: Define to NULL if not defined. This is needed because the MS-Windows build doesn't have a canonical place for LOCALEDIR. (WIN32_LEAN_AND_MEAN) [WINDOWS32]: Define, to avoid getting from windows.h header too much stuff that could conflict with the code. main.c <sync_mutex>: New static variable. <switches>: Add support for "--sync-mutex" switch. (decode_output_sync_flags): Decode the --sync-mutex= switch. (prepare_mutex_handle_string) [WINDOWS32]: New function. (main): Add "output-sync" to .FEATURES. job.h (CLOSE_ON_EXEC) [WINDOWS32]: Define to call process_noinherit. (F_GETFD, F_SETLKW, F_WRLCK, F_UNLCK, struct flock) [WINDOWS32]: New macros. (RECORD_SYNC_MUTEX): New macro, a no-op for Posix platforms. (sync_handle_t): New typedef. job.c <sync_handle>: Change type to sync_handle_t. (FD_NOT_EMPTY): Seek to the file's end. Suggested by Frank Heckenbach <f.heckenbach@fh-soft.de>. (pump_from_tmp_fd) [WINDOWS32]: Switch to_fd to binary mode for the duration of this function, and then change back before returning. (start_job_command) [WINDOWS32]: Support output_sync mode on MS-Windows. Use a system-wide mutex instead of locking stdout/stderr. Call process_easy with two additional arguments: child->outfd and child->errfd. (exec_command) [WINDOWS32]: Pass two additional arguments, both -1, to process_easy, to adjust for the changed function signature. function.c (windows32_openpipe) [WINDOWS32]: This function now returns an int, which is -1 if it fails and zero otherwise. It also calls 'error' instead of 'fatal', to avoid exiting prematurely. (func_shell_base) [WINDOWS32]: Call perror_with_name if windows32_openpipe fails, now that it always returns. This avoids a compiler warning that error_prefix is not used in the MS-Windows build. config.h.W32.template (OUTPUT_SYNC): Define. build_w32.bat: Add w32/compat/posixfcn.c to compilation and linking commands. From Frank Heckenbach <f.heckenbach@fh-soft.de>: job.c (sync_output): Don't discard the output if acquire_semaphore fails; instead, dump the output unsynchronized.
2013-02-28Use ENULLLOOP to handle EINTR during realpath(). Fixes Savannah bug #38420Paul Smith1-13/+21
2013-02-25Expand the loadable object support.Paul Smith1-51/+74
Provide a simple API for loaded objects to interact with GNU make. I still won't guarantee that this API won't change but it's much closer to something that's supported and provides easy-to-use interfaces with a public header file.
2013-01-20Rename struct floc to typedef gmk_floc as an externally scoped symbol.Paul Smith1-1/+1
2013-01-20Rename the make.h file to makeint.h for internal use only.Paul Smith1-2/+2
2012-09-09On BSD, realpath(3) doesn't fail if the target doesn't exist, so testPaul Smith1-4/+2
explicitly with stat(2). Fixes Savannah bug #35919.
2012-03-05Simplify copyrights using ranges of years.Paul Smith1-3/+1
The new GNU Maintainer's Manual allows the use of year ranges in certain situations; take advantage of this simplification.
2012-03-04Create a new CSTRLEN (constant string length) macro, and use it.Paul Smith1-10/+10
2012-03-04Convert all "`'" quotes to "''" per new GNU Coding Standard guidelines.Paul Smith1-15/+15
Fixes Savannah bug #34530.
2012-03-03Fix Savannah bug #35410: handle escape chars in filter/filter-outPaul Smith1-8/+7
Also add a valgrind suppression file for Guile-enabled make.
2012-01-29Create a new function $(file ...)Paul Smith1-0/+40
2012-01-28 Fix failures on MS-Windows when Make's standard handles are invalid.Eli Zaretskii1-19/+54
This can happen when Make is invoked from a GUI application. * w32/subproc/sub_proc.c (process_init_fd): Don't dereference pproc if it is a NULL pointer. (process_begin, process_cleanup): Don't try to close pipe handles whose value is INVALID_HANDLE_VALUE. (process_easy): Initialize hIn, hOut, and hErr to INVALID_HANDLE_VALUE. If DuplicateHandle fails with ERROR_INVALID_HANDLE, duplicate a handle for the null device instead of STD_INPUT_HANDLE, STD_OUTPUT_HANDLE or STD_ERROR_HANDLE. Don't try to close pipe handles whose value is INVALID_HANDLE_VALUE. * function.c (windows32_openpipe): Initialize hIn and hErr to INVALID_HANDLE_VALUE. If DuplicateHandle fails with ERROR_INVALID_HANDLE, duplicate a handle for the null device instead of STD_INPUT_HANDLE or STD_ERROR_HANDLE. Fix indentation. Don't try to close handles whose value is INVALID_HANDLE_VALUE.
2012-01-25 function.c (define_new_function): Fix format strings in calls to `fatal'.Eli Zaretskii1-2/+2
2012-01-16Create a new internal interface for defining new make functions.Paul Smith1-18/+27
This allows us to create new functions without changing function.c. You still have to modify the GNU make code (for now) though: this is simply a preliminary step to possibly allowing make to load modules. Modify the Guile integration to use this method rather than ifdefs in function.c.
2012-01-16Update copyright notices.Paul Smith1-3/+3
2012-01-15Add GNU Guile as an optional embedded scripting language for make.Paul Smith1-0/+18
On configure-enabled systems, configure will detect Guile installed (using pkg-config, which is how GNU Guile is distributed) and enable it if so. On all non-configure-enabled systems, currently, the default is for Guile support to be disabled.
2011-11-14Changes to resolve warnings.Paul Smith1-1/+1
Fixes Savannah bug #34608.
2011-05-02Use the same algorithm for counting the number of words to sort as wePaul Smith1-12/+5
use to break up the list of words, so we're sure to get the same number. Fixes Savannah bug #33125
2011-04-18Add new feature: != shell assignment for portability with BSD make.Paul Smith1-9/+27
Feature submitted by David Wheeler.
2010-08-07 function.c (func_shell) [WINDOWS32]: Reset just_print_flagEli Zaretskii1-3/+18
around the call to construct_command_argv, so that a temporary batch file _is_ created when needed for $(shell). Fixes Savannah bug #16362.
2010-07-13Update copyrights for 2010.Paul Smith1-2/+2
2010-07-09Fix Savannah bug #30312.Eli Zaretskii1-0/+7
function.c (abspath): Support absolute file names in UNC format.
2010-07-09 job.c (pid2str) [WINDOWS32]: Don't use %Id with GCC < 4.x.Eli Zaretskii1-6/+6
(exec_command) [WINDOWS32]: Use pid2str instead of non-portable %Id. main.c (handle_runtime_exceptions): Use %p to print addresses, to DTRT on both 32-bit and 64-bit hosts. Savannah bug #27809. job.c (w32_kill, start_job_command, create_batch_file): Use pid_t for process IDs and intptr_t for the 1st arg of _open_osfhandle. function.c (windows32_openpipe): Use pid_t for process IDs and intptr_t for the 1st arg of _open_osfhandle. (func_shell): Use pid_t for process IDs. main.c (main) [WINDOWS32]: Pacify the compiler. config.h.W32.template (pid_t): Add a definition for 64-bit Windows builds that don't use GCC. Savannah bug #27809. Patch by Ozkan Sezer <sezeroz@gmail.com>
2009-10-25Update copyright years.Paul Smith1-2/+2
2009-10-03- Include <alloca.h> even on non-__GNUC__ systems.Paul Smith1-1/+2
- Add some tests for unresolved bugs.
2009-09-26Fix some memory leaks, found with valgrind.Paul Smith1-0/+1
2009-09-24- Rework secondary expansion so we only defer it if there's a possibilityPaul Smith1-1/+1
it might be needed: for most situations we parse prereqs immediately as we used to. Reduces memory usage. - Fixes Savannah bug #18622.
2009-09-16- Add xcalloc() and call itPaul Smith1-7/+5
- Fix memory errors found by valgrind - Remove multi_glob() and empower parse_file_seq() to do its job: the goal here is to remove the confusing reverse/re-reverse we do on the file lists: needed for future fixes. - Add a prefix arg to parse_file_seq() - Make concat() variadic so it can take arbitrary #'s of strings
2009-08-31 * function.c (windows32_openpipe): Update envp after callingEli Zaretskii1-0/+3
sync_Path_environment.
2009-07-04(func_realpath) [!HAVE_REALPATH]: Require the file to exist, asEli Zaretskii1-1/+4
realpath(3) does where it's supported.
2009-07-04 * function.c (IS_ABSOLUTE, ROOT_LEN): New macros.Eli Zaretskii1-9/+46
(abspath): Support systems that define HAVE_DOS_PATHS (have drive letters in their file names). Use IS_PATHSEP instead of a literal '/' comparison.
2009-06-13- Fix Savannah bug 17825Paul Smith1-18/+12
- Fix Savannah bug 21231
2009-06-09- Fix Savannah bug #18124Paul Smith1-3/+3
- Fix Savannah bug #17521 - Fix Savannah bug #16401 - Fix Savannah bug #16469 - Fix Savannah bug #16473
2009-05-24Found this change in an old CVS workspace: rewrite savestring() to thePaul Smith1-1/+1
more standard xstrndup().
2009-03-07 * function.c (func_shell): Don't close pipedes[1] if it is -1.Eli Zaretskii1-2/+5
Fixes Savannah bug #20495.
2007-10-10Fixes from Eli Zaretskii:Paul Smith1-3/+4
Fix to allow quoted directories in PATH. Fix for Savannah bug #20549.
2007-07-04* Update to GPLv3Paul Smith1-4/+4
* Update copyright to 2007 * Fix download URL for translation files (thanks to Thiemo Seufer)
2007-05-11Fix some documentation gitches.Paul Smith1-1/+1
Fix an uninitialized variable. Add builtin rules for Objective C. Add a new debug line that shows where the commands that are about to be run were defined.
2007-05-09Fix Savannah bug #19656: rationalize our use of case-insensitive stringPaul Smith1-1/+1
comparison functions to always use POSIX strcasecmp(). For non-POSIX systems that use other functions (strcmpi or stricmp) use a macro to alias strcasecmp to those. If we can't find any of them (VMS, plus whatever UNIX doesn't have them) then define our own version in misc.c.
2007-03-20This is a major update, which switches virtually every allocated-but-not-freedPaul Smith1-183/+183
string into the strcache. As a side-effect, many more structure members and function arguments can/should be declared const. As mentioned in the changelog, unfortunately measurement shows that this change does not yet reduce memory. The problem is with secondary expansion: because of this we store all the prerequisites in the string cache twice. First we store the prerequisite string after initial expansion but before secondary expansion, then we store each individual file after secondary expansion and expand_deps(). I plan to change expand_deps() to be callable in either context (eval or snap_deps) then have non-second-expansion targets call expand_deps() during eval, so that we only need to store that dependency list once.
2006-11-18Fix from Eli for incorrect value of $(MAKE) on Cygwin.Paul Smith1-34/+45
A few changes from char* to void* where appropriate, and removing of unnecessary casts. Much more work on const-ifying the codebase. This round involves some code changes to make it correct. NOTE!! There will almost certainly be problems on the non-POSIX ports that will need to be addressed after the const changes are finished: they will need to be const-ified properly and there may need to be some changes to allocate memory, etc. as well. The next (last?) big push for this, still to come, is const-ifying the filenames in struct file, struct dep, etc. This will allow us to store file names in the string cache and finally resolve Savannah bug #15182 (make uses too much memory), among other advantages.