From 5485845edafde360cd43f035ca329cfe3baba49a Mon Sep 17 00:00:00 2001 From: Frode Aannevik Date: Wed, 25 May 2016 17:30:00 +0200 Subject: remove adding parameters action in the EnvironmentContributor move it back to BitbucketBuildTrigger to fix the the problem that a lot of empty "Parameters" links are added to each build --- .../BitbucketAdditionalParameterEnvironmentContributor.java | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'src/main/java/bitbucketpullrequestbuilder/bitbucketpullrequestbuilder/BitbucketAdditionalParameterEnvironmentContributor.java') diff --git a/src/main/java/bitbucketpullrequestbuilder/bitbucketpullrequestbuilder/BitbucketAdditionalParameterEnvironmentContributor.java b/src/main/java/bitbucketpullrequestbuilder/bitbucketpullrequestbuilder/BitbucketAdditionalParameterEnvironmentContributor.java index a4ff97d..c531ca1 100644 --- a/src/main/java/bitbucketpullrequestbuilder/bitbucketpullrequestbuilder/BitbucketAdditionalParameterEnvironmentContributor.java +++ b/src/main/java/bitbucketpullrequestbuilder/bitbucketpullrequestbuilder/BitbucketAdditionalParameterEnvironmentContributor.java @@ -5,7 +5,6 @@ import hudson.Extension; import hudson.model.*; import java.io.IOException; -import java.util.ArrayList; @Extension public class BitbucketAdditionalParameterEnvironmentContributor extends EnvironmentContributor { @@ -18,8 +17,6 @@ public class BitbucketAdditionalParameterEnvironmentContributor extends Environm return; } - run.addAction(getDefaultParameters(run)); - putEnvVar(envVars, "sourceBranch", cause.getSourceBranch()); putEnvVar(envVars, "targetBranch", cause.getTargetBranch()); putEnvVar(envVars, "repositoryOwner", cause.getRepositoryOwner()); @@ -40,14 +37,4 @@ public class BitbucketAdditionalParameterEnvironmentContributor extends Environm return actual == null ? d : actual; } - private ParametersAction getDefaultParameters(Run run) { - ArrayList values = new ArrayList(); - ParametersDefinitionProperty definitionProperty = run.getParent().getProperty(ParametersDefinitionProperty.class); - if (definitionProperty != null) { - for (ParameterDefinition pd : definitionProperty.getParameterDefinitions()) { - values.add(pd.getDefaultParameterValue()); - } - } - return new ParametersAction(values); - } } -- cgit v1.2.3